Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

Wolfgang Bauer wbauer at
Sat Jan 4 16:54:32 GMT 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 4, 2014, 5:54 p.m.)

Review request for kde-workspace and David Stephen Hubner.


Addressed the mentioned issue.

Repository: kde-workspace


This patch reimplements the ReadPipe() function by using QProcess instead of popen().
This should make it more portable.

As a positive side-effect, this also removes those "sh: lspci: command not found." messages when run in Konsole and lspci is not in the user's path.

This was suggested on the kde-core-devel mailinglist in November:

Diffs (updated)

  kinfocenter/Modules/opengl/opengl.cpp 8901957 



Ran KInfocenter with lspci in /usr/bin/ (i.e. in the user's path) and /sbin/ (not in the user's path). The OpenGL module showed the 3D accelerator info correctly in both cases.
With lspci removed completely it showed "unknown" as expected.


Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list