Review Request 114807: Don't dim display if backlight brightness is already 0

[Alexander Mezin]

> On Jan. 2, 2014, 5:58 p.m., Àlex Fiestas wrote:
> > Looks good, I have been suffering from this too !

Most probably this patch won't solve your problem.

There is also a bug in Intel driver. It changes backlight brightness when queried with XRandr. It's fixed only in 2.99.905 and only for SNA backend. https://bugs.freedesktop.org/show_bug.cgi?id=73181


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114807/#review46603
-----------------------------------------------------------


On Jan. 2, 2014, 7:14 p.m., Alexander Mezin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114807/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2014, 7:14 p.m.)
> 
> 
> Review request for kde-workspace and Dario Freddi.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Some drivers report backlight brightness == 0 when display is switched off with DPMS (for example, Intel driver on my laptop).
> If screen was switched off before dimming was started, it remembers 0 as previous backlight level. When I move mouse/press key, display doesn't switch on, because powerdevil sets brightness to 0.
> This patch fixes the problem for me. It just doesn't change backlight brightness if it's already 0.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/actions/bundled/dimdisplay.h f917d71 
>   powerdevil/daemon/actions/bundled/dimdisplay.cpp 39e0636 
> 
> Diff: https://git.reviewboard.kde.org/r/114807/diff/
> 
> 
> Testing
> -------
> 
> It works on my laptop.
> 
> 
> Thanks,
> 
> Alexander Mezin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140102/553c7b81/attachment.htm>