Review Request 114807: Don't dim display if backlight brightness is already 0

Alexander Mezin mezin.alexander at gmail.com
Thu Jan 2 12:14:22 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114807/
-----------------------------------------------------------

(Updated Jan. 2, 2014, 12:14 p.m.)


Status
------

This change has been marked as submitted.


Review request for kde-workspace and Dario Freddi.


Repository: kde-workspace


Description
-------

Some drivers report backlight brightness == 0 when display is switched off with DPMS (for example, Intel driver on my laptop).
If screen was switched off before dimming was started, it remembers 0 as previous backlight level. When I move mouse/press key, display doesn't switch on, because powerdevil sets brightness to 0.
This patch fixes the problem for me. It just doesn't change backlight brightness if it's already 0.


Diffs
-----

  powerdevil/daemon/actions/bundled/dimdisplay.h f917d71 
  powerdevil/daemon/actions/bundled/dimdisplay.cpp 39e0636 

Diff: https://git.reviewboard.kde.org/r/114807/diff/


Testing
-------

It works on my laptop.


Thanks,

Alexander Mezin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140102/2b3449f2/attachment.htm>


More information about the kde-core-devel mailing list