Review Request 116073: Do not use encoded URL when creating relative symlinks

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116073/#review50995
-----------------------------------------------------------


This review has been submitted with commit 9fd3e380f3f1967b8ba01c5a248b6cddf79450a7 by Dawit Alemayehu to branch KDE/4.12.

- Commit Hook


On Feb. 26, 2014, 7:19 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116073/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 7:19 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Bugs: 330463
>     http://bugs.kde.org/show_bug.cgi?id=330463
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> When creating symlinks in KNewFileMenuPrivate::_k_slotSymLink, call prettyUrl() instead url() to retrieve the user entered text. Otherwise, a percent encoded version of the URL will be used to create the symlink which of course results in the creation of an invalid symlink. Note that this call needs to probably be changed toString() in kf5 since it is using QUrl.
> 
> 
> Diffs
> -----
> 
>   kfile/knewfilemenu.cpp e7fe237 
> 
> Diff: https://git.reviewboard.kde.org/r/116073/diff/
> 
> 
> Testing
> -------
> 
> Follow the steps outlined in the bug report to create a symlink to a file whose path or name contains characters that are not allowed in a URL.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140227/4e5afebc/attachment.htm>