Review Request 116077: KRunner patch so it detects Iceweasel bookmarks

Maximiliano Curia maxy at debian.org
Wed Feb 26 14:07:11 GMT 2014



> On Feb. 26, 2014, 1:15 p.m., Sebastian K├╝gler wrote:
> > Patch looks sensible. Do you have a Git account at KDE?

Hi,

No, I don't have a git account, but you are the third person that ask me that, maybe I should request one. Either way, could you please commit the change?

Thanks for the review.


- Maximiliano


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116077/#review50930
-----------------------------------------------------------


On Feb. 26, 2014, 10:48 a.m., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116077/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 10:48 a.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Bugs: 322399
>     http://bugs.kde.org/show_bug.cgi?id=322399
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Hi,
> 
> This patch was submitted to the bug tracker some time ago, and even longer in the debian bug tracker, here is the original report: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=646612
> 
> Thanks,
> 
> 
> Diffs
> -----
> 
>   plasma/generic/runners/bookmarks/browserfactory.cpp 7f29f5efd8817983db67c496b850d1caba4d8046 
> 
> Diff: https://git.reviewboard.kde.org/r/116077/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140226/e55a5d0d/attachment.htm>


More information about the kde-core-devel mailing list