Review Request 116017: Implement POST -> POST redirection support in KIO

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116017/
-----------------------------------------------------------

(Updated Feb. 26, 2014, 8:34 a.m.)


Review request for kdelibs, Andrea Iacovitti and David Faure.


Changes
-------

Updated version of the patch that cleans up the HTTP protocol changes and tested using both webkit and khtml engines against the greenbytes test server.


Repository: kdelibs


Description
-------

The attached patch implements support for redirecting one POST request to another in KIO. Unless implicitly disabled currently the automatic redirection handler in KIO always redirects any POST requests to a GET.

Note this patch also changes the original KIO::http_post implementation that accepted a QByteArray to simply store the data in a QBuffer and call the newer implementation that uses a QIODevice. I have updated the documentation for the original implementation to state as such and encourage developers to directly use the newer http_post method instead. Not sure if everyone will agree with my implementation but it makes it much easier to resend POST data on redirection.


Diffs (updated)
-----

  kio/kio/job.h aeaffa2 
  kio/kio/job.cpp edc5fed 
  kio/kio/job_p.h 5ead3ed 
  kioslave/http/http.cpp 9eba5d1 

Diff: https://git.reviewboard.kde.org/r/116017/diff/


Testing
-------

http://greenbytes.de/tech/tc/httpredirects/t307methods.html
http://greenbytes.de/tech/tc/httpredirects/t308methods.html


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140226/a23e13bc/attachment.htm>