Review Request 116017: Implement POST -> POST redirection support in KIO

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116017/#review50701
-----------------------------------------------------------


Just typos and docu issues, the core of the fix seems ok to me.


kio/kio/job.h
<https://git.reviewboard.kde.org/r/116017/#comment35606>

    the the -> the



kio/kio/job.h
<https://git.reviewboard.kde.org/r/116017/#comment35614>

    "recommended you use the function for when..." - rather unclear. Which function? In the commit log you said you wanted to encourage using the QIODevice overload directly (which I assume this is trying to do, although not clearly).
    
    But even then I don't think it makes sense. Anyone who has a QByteArray on their hands should call the function with a QByteArray rather than just create a QBuffer in order to be able to call the "recommended function" -- all this achieves is duplicating that bit of code into the apps.
    
    I would suggest removing the whole note, simply. Two overloads = pick the most convenient one for the calling code.
    



kio/kio/job.h
<https://git.reviewboard.kde.org/r/116017/#comment35607>

    inconsistent spaces in ( ... ), remove them (on the line before, too).



kio/kio/job.h
<https://git.reviewboard.kde.org/r/116017/#comment35609>

    These @p don't refer to actual parameters in this method, this will confuse doxygen.



kio/kio/job.h
<https://git.reviewboard.kde.org/r/116017/#comment35608>

    typeas -> type as


- David Faure


On Feb. 24, 2014, 2:07 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116017/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 2:07 p.m.)
> 
> 
> Review request for kdelibs, Andrea Iacovitti and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The attached patch implements support for redirecting one POST request to another in KIO. Unless implicitly disabled currently the automatic redirection handler in KIO always redirects any POST requests to a GET.
> 
> Note this patch also changes the original KIO::http_post implementation that accepted a QByteArray to simply store the data in a QBuffer and call the newer implementation that uses a QIODevice. I have updated the documentation for the original implementation to state as such and encourage developers to directly use the newer http_post method instead. Not sure if everyone will agree with my implementation but it makes it much easier to resend POST data on redirection.
> 
> 
> Diffs
> -----
> 
>   kio/kio/job.h aeaffa2 
>   kio/kio/job.cpp 9cf2b57 
>   kioslave/http/http.cpp 9eba5d1 
> 
> Diff: https://git.reviewboard.kde.org/r/116017/diff/
> 
> 
> Testing
> -------
> 
> http://greenbytes.de/tech/tc/httpredirects/t307methods.html
> http://greenbytes.de/tech/tc/httpredirects/t308methods.html
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140224/c71445f0/attachment.htm>