Review Request 115864: kio_http: fixes for 30X response code redirection handling

Andrea Iacovitti aiacovitti at
Wed Feb 19 21:50:23 GMT 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 19, 2014, 9:50 p.m.)

Review request for kdelibs and Dawit Alemayehu.


Added new member "sentMethodString" to cache the http method actually sent by the request, after being determined in sendQuery().
The purpose is to reduce overhead while parsing the response.
Minor: modified HTTPRequest::methodString() to return the method string without additional trailing white space.

Repository: kdelibs


Check if method has been overridden via "CustomHTTPMethod" metaData when redirecting POST to GET in case of 301/302 response code.
Handle "308 Permanent Redirect" response code.

Diffs (updated)

  kioslave/http/http.h 076ad2b 
  kioslave/http/http.cpp 68b5247 
  kioslave/http/httpauthentication.cpp 80d7995 




Andrea Iacovitti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list