Review Request 115864: kio_http: fixes for 30X response code redirection handling

Dawit Alemayehu adawit at kde.org
Wed Feb 19 04:20:32 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115864/#review50188
-----------------------------------------------------------



kioslave/http/http.cpp
<https://git.reviewboard.kde.org/r/115864/#comment35291>

    I think 301 can simply do the setMetaData call and pass on through 302 instead of duplicating the same exact code. 


- Dawit Alemayehu


On Feb. 18, 2014, 9:36 a.m., Andrea Iacovitti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115864/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 9:36 a.m.)
> 
> 
> Review request for kdelibs and Dawit Alemayehu.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Check if method has been overridden via "CustomHTTPMethod" metaData when redirecting POST to GET in case of 301/302 response code.
> Handle "308 Permanent Redirect" response code.
> 
> 
> Diffs
> -----
> 
>   kioslave/http/http.cpp 68b5247 
> 
> Diff: https://git.reviewboard.kde.org/r/115864/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Iacovitti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140219/debebe39/attachment.htm>


More information about the kde-core-devel mailing list