Review Request 112294: Implement multi-seat support in KDM

[Aaron J. Seigo]

> On Sept. 3, 2013, 10:20 p.m., Oswald Buddenhagen wrote:
> > given that there is no intention to make further feature releases of the kde workspace which will include kdm, i wonder why we'd go through the (potentially tedious) process of upstreaming this now?
> 
> Stefan Brüns wrote:
>     The reason for sending this was to have one canonical implementation for multiseat support which is upstream.
>     Otherwise, any patches/bugreports must be coordinated downstream, which I really dislike.
>     
>     Reason for pushing this into KDM is that:
>     a) KDM is here today and will stay for some time
>     b) this patch has been tested thoroughly
>     c) alternative DMs are not up to the job yet (SDDM) or introduce additional dependencies (GDM)
>     d) I want multiseat support in the DM now, not in a distant future
> 
> Oswald Buddenhagen wrote:
>     that's besides the point. whatever gets merged now will never be released. i'm not quite sure why the responsible persons didn't rm -rf the directories yet.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     Well, at least it gives distros somewhere to pick the patch from.
> 
> Oswald Buddenhagen wrote:
>     provided any distro still wants to make a new feature release.
>     anyway, you'll understand that my motivation to invest effort into this is kinda low, time constraints notwithstanding.
>     i may reconsider if i see credible support for such a patch from multiple downstreams here.
>

There is ~1.5 years of releases of kde-workspace 4.x left to come. They are maintenance releases, but releases all the same. So yes, upstreaming this would see the light of day as a 4.11.x release.


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112294/#review39302
-----------------------------------------------------------


On Sept. 2, 2013, 11:34 p.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112294/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2013, 11:34 p.m.)
> 
> 
> Review request for kde-workspace and Oswald Buddenhagen.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> This patch implements dynamic multiseat in KDM. It follows the description in:
> http://www.freedesktop.org/wiki/Software/systemd/writing-display-managers/
> 
> In case systemd is no found at compile time, nothing changes. If logind is not running, nothing changes. If no additional seats have been configured (some Plugable USB-GPUs are automatically added as additional seats), nothing changes.
> 
> In case there are additional seats beyond seat0, a reserved display is promoted to a local static one (and demoted if the seat is removed) and a new X-Server/greeter is spawned.
> 
> The code has been tested extensively, with a combination of [Radeon dedicated GPU|Intel iGPU], [Intel iGPU|Displaylink USB GPU] and others. For history of this patch, see https://bugzilla.redhat.com/show_bug.cgi?id=884271 and https://bugzilla.redhat.com/show_bug.cgi?id=975079
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a3bdbb3 
>   cmake/modules/CMakeLists.txt 117b3a5 
>   cmake/modules/FindSystemd.cmake PRE-CREATION 
>   kdm/backend/CMakeLists.txt 25f383f 
>   kdm/backend/client.c 26bb0b4 
>   kdm/backend/dm.h 64e106b 
>   kdm/backend/dm.c e0f1366 
>   kdm/backend/server.c d8dd6f3 
>   kdm/backend/session.c 0e7901c 
> 
> Diff: https://git.reviewboard.kde.org/r/112294/diff/
> 
> 
> Testing
> -------
> 
> Single seat system, several multiseat systems
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140218/adb146f7/attachment.htm>