Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

[Thomas Lübking]

> On Feb. 8, 2014, 2:34 p.m., Thomas Lübking wrote:
> > Here's my vote then.
> > Unless there's concern, push it "in some days™" (ie. tuesday or so, should leave enough time to cry out)
> 
> kdeuser56 kdeuser56 wrote:
>     "push it" sounds like I should push it, however I can't do it, as I do not have a dev account. Could you push it for me? 
>     Pushing in frameworks/kio would also be nice (diff can be found here: http://pastebin.kde.org/p7eahjnoq)!
> 
> kdeuser56 kdeuser56 wrote:
>     Thomas: Would you mind shipping it for me?

I'd have to setup a frameworks build first.
I'll push it then if that didn't happen otherwise, but Frank might want to push it before.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115408/#review49252
-----------------------------------------------------------


On Feb. 8, 2014, 10:02 a.m., kdeuser56 kdeuser56 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115408/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2014, 10:02 a.m.)
> 
> 
> Review request for kdelibs and Frank Reininghaus.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The iconbutton and the iconlabel were clearly aligned using the old style, when everything was left aligned.
> In my interpretation of the KDE HIG guidelines, the iconbutton/label should also be right aligned.  
> Especially with bigger font sizes, the visual issue becomes obvious. 
> 
> Idea: see kproperties-dolphin-1.png
> Before: see before-1.png and before-2.png 
> After: see after-1.png and after-2.png
> 
> Diff for kio (frameworks) can be found here: http://pastebin.kde.org/p4ojv6a1w
> 
> 
> Diffs
> -----
> 
>   kio/kfile/kpropertiesdialog.cpp 6611ee7 
> 
> Diff: https://git.reviewboard.kde.org/r/115408/diff/
> 
> 
> Testing
> -------
> 
> Compiled and installed. Works as expected. 
> 
> 
> File Attachments
> ----------------
> 
> idea
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png
> before1
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png
> before2
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png
> after1
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png
> after2
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png
> center-center
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/ab93b637-e914-4521-a9c5-025515c97790__widget-center-icon-center.png
> left-left
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/38cd56fb-c411-4876-bebe-bc9923855751__widget-left-icon-leftunpatched.png
> right-center
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/80672290-b6fb-4fe3-b2ab-5ea5f0c6ed53__widget-right-icon-center.png
> right-right
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/8dec5429-021a-49a0-a34f-1a2e77d7aeef__widget-right-icon-right.png
> 
> 
> Thanks,
> 
> kdeuser56 kdeuser56
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140217/44e3efd6/attachment.htm>