Review Request 115651: Fix HTTP redirection handling (3XX status code)

[Rolf Eike Beer]

Am Mittwoch, 12. Februar 2014, 17:10:49 schrieb Andrea Iacovitti:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115651/#review49669
> -----------------------------------------------------------
> 
> 
> As stated in the bug report it is also true that every other browsers
> rewrite POST method to GET when following 301/302 redirections. This
> behavior could also be verified in curl by issuing the following commands:
> curl -L --data "fakepostdata"
> http://greenbytes.de/tech/tc/httpredirects/redirect_with_status.cgi?301
> curl -L --data "fakepostdata"
> http://greenbytes.de/tech/tc/httpredirects/redirect_with_status.cgi?302 We
> could/should do the same for compatibility.
> In that case the snippet of code that handles 301-303 http status codes may
> assume this form:
> 
>         } else if (m_request.responseCode >= 301 && m_request.responseCode<=
> 303) { // NOTE: This is wrong according to RFC 2616 (section 10.3.[2-4,8]).
> // However, because almost all client implementations treat a 301/302 //
> response as a 303 response in violation of the spec, many servers // have
> simply adapted to this way of doing things! Thus, we are // forced to do
> the same thing. Otherwise, we loose compatibility and // might not be able
> to correctly retrieve sites that redirect. if (m_request.responseCode ==
> 301) { // Moved permanently
> setMetaData(QLatin1String("permanent-redirect"), QLatin1String("true")); if
> (m_request.method == HTTP_POST) {
>                     m_request.method = HTTP_GET; // FORCE a GET
>                     setMetaData(QLatin1String("redirect-to-get"),
> QLatin1String("true")); }
>             } else if (m_request.responseCode == 302) { // Moved temporarily
> if (m_request.method == HTTP_POST) {
>                     m_request.method = HTTP_GET; // FORCE a GET
>                     setMetaData(QLatin1String("redirect-to-get"),
> QLatin1String("true")); }
>             } else { // 303 See Other
>                 if (m_request.method != HTTP_HEAD) {
>                     m_request.method = HTTP_GET; // FORCE a GET
>                     setMetaData(QLatin1String("redirect-to-get"),
> QLatin1String("true")); }
>             }
>         }
> 
> ...or something like that.

switch () { … }

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140213/4b68cec2/attachment.sig>