Review Request 115689: Fix khtml/ecma/xmlhttprequest.cpp to properly handle HEAD requests

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115689/
-----------------------------------------------------------

(Updated Feb. 12, 2014, 9:56 a.m.)


Review request for kdelibs and Andrea Iacovitti.


Changes
-------

Uploaded the patch. 

Please note that the relevant patch to this pull request is the one that changes khtml/ecma/xmlhttprequest.cpp and adds "CMD_STAT" to TransferJob::slotFinished's switch statement. Unfortunately, this patch depends on another one that is currently in review, https://git.reviewboard.kde.org/r/115651/, hence the posted patch here contains the changes from that review request as well.


Bugs: 331007
    http://bugs.kde.org/show_bug.cgi?id=331007


Repository: kdelibs


Description
-------

Fix khtml/ecma/xmlttprequest.cpp such that it correctly handles HEAD requests without a noticable delay, i.e. use KIO::mimeType instead of KIO::get. Otherwise, the request will wait for the content which is not returned when doing a stat operation like HEAD.


Diffs (updated)
-----

  khtml/ecma/xmlhttprequest.cpp b3707e7 
  kio/DESIGN.metadata 1351119 
  kio/kio/accessmanager.cpp 7a806e8 
  kio/kio/job.cpp 13107c2 
  kioslave/http/http.cpp b13eed1 

Diff: https://git.reviewboard.kde.org/r/115689/diff/


Testing
-------

Tested HEAD redirection with http://greenbytes.de/tech/tc/httpredirects/


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140212/ad76d6ad/attachment.htm>