Review Request 115492: Add WebP detection from content in the mime package file

[David Faure]

> On Feb. 8, 2014, 5:41 p.m., David Faure wrote:
> > Please consider submitting this mimetype to freedesktop.org.xml instead.
> > 
> > https://bugs.freedesktop.org
> 
> David Faure wrote:
>     OK, s/instead/in addition/.
> 
> Alex Merry wrote:
>     Sorry, failed to record a conversation that happened on irc.  Basically: https://bugs.freedesktop.org/show_bug.cgi?id=41155
> 
> Àlex Fiestas wrote:
>     Given the outcome of the bug, should we go ahead and implement our own thing?

No.

Shared-mime-info shall not fork IANA, and KDE shall not fork shared-mime-info.

In fact your question doesn't even make sense, since this commit is about image/x-webp and that is exactly the name that got into shared-mime-info, so there's no conflict there, and therefore no reason to fork anything.

Very similar "magic" got into s-m-i (just without the VP8), so this can go in without the VP8, and with a comment "remove when we can depend on shared-mime-info 1.3".


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115492/#review49268
-----------------------------------------------------------


On Feb. 5, 2014, 2:44 p.m., Jerome Leclanche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115492/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 2:44 p.m.)
> 
> 
> Review request for KDE Runtime and Alex Merry.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> This adds match detection for webp files (both lossy and lossless), the same way as audio/x-wav files are detected (both are RIFF based)
> 
> 
> Diffs
> -----
> 
>   kimgio/webp.xml 4246f76 
> 
> Diff: https://git.reviewboard.kde.org/r/115492/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jerome Leclanche
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140211/5f93558d/attachment.htm>