Review Request 121746: avoid wrong trash size calculation when removing file from trash and cached size info is wrong

[Martin Koller]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121746/
-----------------------------------------------------------

(Updated Dec. 29, 2014, 11:08 p.m.)


Status
------

This change has been discarded.


Review request for KDE Runtime, David Faure and Tobias Koenig.


Bugs: 245482
    http://bugs.kde.org/show_bug.cgi?id=245482


Repository: kde-runtime


Description
-------

The trash kio-slave stores the current trash size in a KConfig cache file.
However it can happen that the information inside this file is wrong, e.g. when another (non-KDE) program puts some files into the trash.
This happens e.g. by using the ebook management software "calibre" when I delete a book. calibre implements the FDO trash specification on its own and therefore knows nothing about the KDE size cachefile.

This leads to the problem that when I move a file out of the trash which was put there by calibre, the subtraction underflows the cached size value resulting in a wrong huge absolute number, finally leading to the bug described here:
https://bugs.kde.org/show_bug.cgi?id=245482


Diffs
-----

  kioslave/trash/trashsizecache.cpp 2fae964 

Diff: https://git.reviewboard.kde.org/r/121746/diff/


Testing
-------

- unit tests
- calibre


Thanks,

Martin Koller

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141229/1f3d5c1b/attachment.htm>