Review Request 121511: Fix to allow kfilemetainfo.h and kfilemetainfo.cpp to build

Paul Manners paul.manners at gmail.com
Sun Dec 14 15:38:51 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121511/
-----------------------------------------------------------

Review request for kdelibs.


Repository: kdelibs


Description
-------

Appears to be a syntax issue with kfilemetainfo.h and kfilemetainfo.cpp that is breaking the build of kdelibs in the 4.13 branch.


Diffs
-----

  kio/kio/kfilemetainfo.h 6920ffe 
  kio/kio/kfilemetainfo.cpp 84fb329 

Diff: https://git.reviewboard.kde.org/r/121511/diff/


Testing
-------

This appears to be a syntax error. 

This was causing problems when doing a build under Windows (with emerge kdelibs under mingw4).  Checking the source code of the kdelibs package in Ubuntu (13.10), it appears to also suffer from the same error so this may be a bigger issue than just on this branch. 

This fixes the build but I don't know how to check if it impacts any of the other applications.  


Thanks,

Paul Manners

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141214/ba6a6818/attachment.htm>


More information about the kde-core-devel mailing list