Review Request 121248: Don't exclude /dev/shm from the possible directories to watch

Frank Reininghaus frank78ac at googlemail.com
Thu Dec 11 22:21:43 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121248/#review71836
-----------------------------------------------------------


Thanks for looking into this! The change looks fine to me. Please add David Faure as reviewer, who is probably familiar with the code. If he does not raise any objections during the next few days, I guess this is good to go in.

I'm not sure if there will be another kdelibs release though (maybe there will be a bugfix release? I see that code is still being committed to the KDE/4.14 branch, which would be pointless otherwise). If not, the patch can at least be used for the next KF5 release, to which it should be forward-ported anyway.

- Frank Reininghaus


On Nov. 25, 2014, 8:15 nachm., Alberto Sánchez Molero wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121248/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2014, 8:15 nachm.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Don't exclude /dev/shm from the possible directories to watch
> 
> 
> Diffs
> -----
> 
>   kdecore/io/kdirwatch.cpp 08b2c119e1f6904f1cce3d05b8bc9c901db2a972 
> 
> Diff: https://git.reviewboard.kde.org/r/121248/diff/
> 
> 
> Testing
> -------
> 
> It compiles fine and it solves bug #314982. It doesn't seem to break any other part of the system.
> 
> 
> Thanks,
> 
> Alberto Sánchez Molero
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141211/2f9774f6/attachment.htm>


More information about the kde-core-devel mailing list