Review Request 121361: DeviceAutomounter Settings ui texts are misleading, if not plain wrong.

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121361/#review71555
-----------------------------------------------------------


The patch just fixes two occurrences of confusion, but leaves others. (See inline for one example.)

It should probably be an approach that fixes the confusion once and for all. With the naming wrong in the code, bugs are bound to creep in again at a later point.


solid-device-automounter/kcm/DeviceAutomounterKCM.ui
<https://git.reviewboard.kde.org/r/121361/#comment49907>

    Well, with this change, the whatsthis and I suppose the function of this checkbox does the exact opposite of its name.
    
    automountUnknownDevices now means "only automount know devices".


- Sebastian Kügler


On Dec. 5, 2014, 7:06 p.m., Frank Schütte wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121361/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 7:06 p.m.)
> 
> 
> Review request for kdelibs, Solid, Christoph Feck, and Helio Castro.
> 
> 
> Bugs: 243046 and 261376
>     http://bugs.kde.org/show_bug.cgi?id=243046
>     http://bugs.kde.org/show_bug.cgi?id=261376
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> automounterrc has four settings:
> [General]
> AutomountEnabled=true
> AutomountOnLogin=false
> AutomountOnPlugin=false
> AutomountUnknownDevices=true
> 
> The ui text for AutomountUnknownDevices says the opposite of its functionality. This is repaired by the patch. Login/Plugin enable/disable overrides. I tried to clarify this a little bit.
> 
> 
> Diffs
> -----
> 
>   solid-device-automounter/kcm/DeviceAutomounterKCM.ui 3827e95 
> 
> Diff: https://git.reviewboard.kde.org/r/121361/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frank Schütte
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141208/04904bd1/attachment.htm>