Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116481/#review65591
-----------------------------------------------------------



a/powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp
<https://git.reviewboard.kde.org/r/116481/#comment45843>

    https://techbase.kde.org/Policies/Kdelibs_Coding_Style
    
    if () {
    
    } else ... {
    
    }
    
    Quote from the coding style:
    "Use curly braces even when the body of a conditional statement contains only one line."



a/powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp
<https://git.reviewboard.kde.org/r/116481/#comment45844>

    curly braces..


- Mark Gaiser


On feb 28, 2014, 1:53 p.m., Joschi Brauchle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116481/
> -----------------------------------------------------------
> 
> (Updated feb 28, 2014, 1:53 p.m.)
> 
> 
> Review request for kde-workspace and Kai Uwe Broulik.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=253453
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=253453
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Currently powerdevil uses the "time-to-empty" property provided by upower to add up battery life for all installed batteries. 
> Unfortunately, upower 0.9.x does not provide a "time-to-empty" for fully charged batteries.
> Hence, the remaining battery lifetime displayed by powerdevil considers only batteries which are currently being discharged and ignores all fully charged batteries.
> 
> The proposed patch is taken from upower 0.99.x and sums up the total energy available in all installed batteries (discharging and charged) and divides it by the current total discharge rate over all batteries (this is for lifetime, similarly for charge time).
> 
> 
> Diffs
> -----
> 
>   a/powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp eae5436 
> 
> Diff: https://git.reviewboard.kde.org/r/116481/diff/
> 
> 
> Testing
> -------
> 
> Tested with KDE 4.11.6 on Thinkpad T440s with 
> - two batteries installed
> - one battery installed
> 
> 
> Thanks,
> 
> Joschi Brauchle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140831/ce76bc88/attachment.htm>