Review Request 119211: Queue CMD_REPARSECONFIGRATION requests for suspended ioslaves

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119211/
-----------------------------------------------------------

(Updated Aug. 30, 2014, 2:07 p.m.)


Status
------

This change has been discarded.


Review request for kdelibs, David Faure and Thiago Macieira.


Repository: kdelibs


Description
-------

This patch addresses the issue where attempting to send CMD_REPARSECONFIGURATION to suspended ioslaves results in a freezing of the application that sent the request. This problem can be clearly reproduced by following the steps outlined in the bug report.

I am not entirely sure whether or not this fix really belongs in kio/connection.cpp, but I could not find a more convenient location to queue the command request to ensure the ioslave receives the reparse configuration command if it is ever reused again.


Diffs
-----

  kio/kio/connection.cpp 99aea0b 

Diff: https://git.reviewboard.kde.org/r/119211/diff/


Testing
-------

Run the steps given in the bug report before and after the fix.


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140830/5be0e2ad/attachment.htm>