Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117175/#review64594
-----------------------------------------------------------

Ship it!


the explicit listing of themes is ok, puts it in line with plasmapkg2.
dead code should be removed before shipping


plasma/tools/plasmapkg/main.cpp
<https://git.reviewboard.kde.org/r/117175/#comment45142>

    never comment dead code, if it should be removed, should just be deleted


- Marco Martin


On Apr. 23, 2014, 11:05 p.m., Andrei Amuraritei wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117175/
> -----------------------------------------------------------
> 
> (Updated Apr. 23, 2014, 11:05 p.m.)
> 
> 
> Review request for KDE Runtime, Aaron J. Seigo, Ian Monroe, and Lamarque Souza.
> 
> 
> Bugs: 306279 and 325028
>     http://bugs.kde.org/show_bug.cgi?id=306279
>     http://bugs.kde.org/show_bug.cgi?id=325028
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> When installing a new .comic provider from GHNS, it doesn't appear in the installed list on the comic widget.
> This fixes it.
> 
> 
> Diffs
> -----
> 
>   plasma/tools/plasmapkg/main.cpp 61492fe 
> 
> Diff: https://git.reviewboard.kde.org/r/117175/diff/
> 
> 
> Testing
> -------
> 
> Compile, add new comic widget, install new comic providers.
> 
> 
> Thanks,
> 
> Andrei Amuraritei
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140815/a7a6b0a0/attachment.htm>