Review Request 119701: Fix bug #334271 : bad display of Dolphin status bar wdgets when a high DPI resolution is used

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119701/#review64476
-----------------------------------------------------------

Ship it!


Thanks for working on this, and thanks everyone for the comments! Looks good to me - I think that you don't have a git account, right? So we'll push the patch for you and close https://bugs.kde.org/show_bug.cgi?id=334271 .

I agree that there is room for further improvements. At least some of them (like eliding the text and providing a tool tip) could be done directly in KCapacityBar though, such that all applications which use that class benefit from them.

- Frank Reininghaus


On Aug. 12, 2014, 5:28 a.m., Mathieu Tarral wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119701/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 5:28 a.m.)
> 
> 
> Review request for Dolphin and KDE Base Apps.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Fixes display issues of dolphin statusbar widgets when a high DPI value is used (>= 196 for example).
> 
> Changes :
> - remove setFixedHeight to fix vertical alignement
> - changes fixed values in setMaximumWidth from 150 to averageCharWidth of m_label * 15
> 
> So, the font width now respects the dpi settings because averageCharWidth will get it's value.
> But there is still an hardcoded value (15).
> 
> Note : QtCurve seemed to be bugged (see screenshots)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/statusbar/dolphinstatusbar.cpp 169395e 
> 
> Diff: https://git.reviewboard.kde.org/r/119701/diff/
> 
> 
> Testing
> -------
> 
> set DPI to 196 (System Settings -> Appearance -> Fonts)
> run dolphin
> look at widgets width in statusbar
> 
> 
> File Attachments
> ----------------
> 
> show-bug
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/858ff768-864d-4adf-9824-e38e82c7cf66__show-bug.png
> fix-cleanlooks
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/e8484513-446d-4805-b1e8-1315b54f98f3__cleanlooks.png
> fix-oxygen
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/7bc31f0b-fe7b-4ed2-8d53-ca00a994e70a__oxygen.png
> fix-plastique
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/ecf5d4db-4b60-411a-8da9-40d143d9a0e0__plastique.png
> fix-qtcurve-agua
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/599d0de4-f85b-46f1-a33a-465837cdbe78__qtcurve-agua.png
> fix-qcurve-breeze
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/0daa1663-db15-4797-9ba7-1a0d0e471d7f__qtcurve-breeze.png
> fix-qtcurve-default
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/ae97cb7b-2d6b-493d-bba1-4a083e5f7ad7__qtcurve-default.png
> 
> 
> Thanks,
> 
> Mathieu Tarral
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140813/ed7f4ac9/attachment.htm>