Review Request 119701: Fix bug #334271 : bad display of Dolphin status bar wdgets when a high DPI resolution is used

Thomas L├╝bking thomas.luebking at gmail.com
Mon Aug 11 10:58:08 BST 2014



> On Aug. 11, 2014, 12:17 vorm., Christoph Feck wrote:
> > dolphin/src/statusbar/dolphinstatusbar.cpp, line 120
> > <https://git.reviewboard.kde.org/r/119701/diff/1/?file=303675#file303675line120>
> >
> >     Where does the text for the spaceInfo come from? If it is possible to compute the widest string in advance, that would be preferable to hard coded numbers. I can imagine that with some translations, the space could be too small.
> 
> Emmanuel Pescosta wrote:
>     > If it is possible to compute the widest string in advance, that would be preferable to hard coded numbers.
>     
>     This should be done in an seperate review request. (I see some problems here - the space info bar will be too wide in some languages)
>     
>     > I can imagine that with some translations, the space could be too small.
>     
>     We already have a bug report about this problem.

What do you mean "too wide"?
I see where it's "too narrow" to display all text and I also see where you're running out of space in the window to display all items on their minimum size.

The element must be big enough to display all text. Everything else is an obvious bug.

--> If you seriously want to operate on hardcoded sizes, the only way out is to condense the text (remove 2nd level information like "free" which is a static term; ultimately elide the text) and provide full information through a tooltip or similar.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119701/#review64214
-----------------------------------------------------------


On Aug. 10, 2014, 9:34 nachm., Mathieu Tarral wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119701/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2014, 9:34 nachm.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Fixes display issues of dolphin statusbar widgets when a high DPI value is used (>= 196 for example).
> 
> Changes :
> - remove setFixedHeight to fix vertical alignement
> - changes fixed values in setMaximumWidth from 150 to averageCharWidth of m_label * 15
> 
> So, the font width now respects the dpi settings because averageCharWidth will get it's value.
> But there is still an hardcoded value (15).
> 
> Note : QtCurve seemed to be bugged (see screenshots)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/statusbar/dolphinstatusbar.cpp 169395e 
> 
> Diff: https://git.reviewboard.kde.org/r/119701/diff/
> 
> 
> Testing
> -------
> 
> set DPI to 196 (System Settings -> Appearance -> Fonts)
> run dolphin
> look at widgets width in statusbar
> 
> 
> File Attachments
> ----------------
> 
> show-bug
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/858ff768-864d-4adf-9824-e38e82c7cf66__show-bug.png
> fix-cleanlooks
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/e8484513-446d-4805-b1e8-1315b54f98f3__cleanlooks.png
> fix-oxygen
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/7bc31f0b-fe7b-4ed2-8d53-ca00a994e70a__oxygen.png
> fix-plastique
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/ecf5d4db-4b60-411a-8da9-40d143d9a0e0__plastique.png
> fix-qtcurve-agua
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/599d0de4-f85b-46f1-a33a-465837cdbe78__qtcurve-agua.png
> fix-qcurve-breeze
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/0daa1663-db15-4797-9ba7-1a0d0e471d7f__qtcurve-breeze.png
> fix-qtcurve-default
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/ae97cb7b-2d6b-493d-bba1-4a083e5f7ad7__qtcurve-default.png
> 
> 
> Thanks,
> 
> Mathieu Tarral
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140811/4d160df0/attachment.htm>


More information about the kde-core-devel mailing list