Review Request 119593: Ensure there's a platform window before restoring the window geometry and then process the resize

Thomas Lübking thomas.luebking at gmail.com
Mon Aug 4 21:39:22 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119593/
-----------------------------------------------------------

(Updated Aug. 4, 2014, 8:39 nachm.)


Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, and Martin Klapetek.


Summary (updated)
-----------------

Ensure there's a platform window before restoring the window geometry and then process the resize


Repository: kconfig


Description (updated)
-------

summarized

To have this work, this patch is required on Qt:


```diff
diff --git a/src/widgets/kernel/qwidgetwindow.cpp b/src/widgets/kernel/qwidgetwindow.cpp
index 35a526e..d417e41 100644
--- a/src/widgets/kernel/qwidgetwindow.cpp
+++ b/src/widgets/kernel/qwidgetwindow.cpp
@@ -551,6 +551,13 @@ void QWidgetWindow::updateGeometry()
 
     const QMargins margins = frameMargins();
 
+    if (geometry().x() != m_widget->data->crect.x() ||
+        geometry().y() != m_widget->data->crect.y())
+        m_widget->setAttribute(Qt::WA_Moved);
+    if (geometry().width()  != m_widget->data->crect.width() ||
+        geometry().height() != m_widget->data->crect.height())
+        m_widget->setAttribute(Qt::WA_Resized);
+
     m_widget->data->crect = geometry();
     QTLWExtra *te = m_widget->d_func()->topData();
     te->posIncludesFrame= false;
```


Diffs (updated)
-----

  src/gui/kwindowconfig.cpp c3cefb7 

Diff: https://git.reviewboard.kde.org/r/119593/diff/


Testing
-------

See
https://git.reviewboard.kde.org/r/119512/


Thanks,

Thomas Lübking

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140804/bf4cef12/attachment.htm>


More information about the kde-core-devel mailing list