Review Request 119594: fix FileDialog size restorage

Lukáš Tinkl lukas at kde.org
Mon Aug 4 14:00:58 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119594/#review63770
-----------------------------------------------------------

Ship it!


Great, this works for me :) Now what about https://git.reviewboard.kde.org/r/119593/

- Lukáš Tinkl


On Srp. 4, 2014, 1:57 odp., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119594/
> -----------------------------------------------------------
> 
> (Updated Srp. 4, 2014, 1:57 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, and Martin Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> - saving in the deconstrutor is insufficient,
>   the dialog might survive the runtime
>   -> needs to be saved when the dialog is finished or just closed
>   (the closeEvent is not invoked if at least a sync dialog is finished)
> 
> - ensure a windowHandle and then restore the window size before calling ::exec()
>     
> - workaround an apparent QWidget QPA bug where even for a created platform window
>   the QWindow geometry is not applied on the QWidget
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformfiledialogbase.cpp b823bc7 
>   src/platformtheme/kdeplatformfiledialogbase_p.h 8ef5b1e 
>   src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 
> 
> Diff: https://git.reviewboard.kde.org/r/119594/diff/
> 
> 
> Testing
> -------
> 
> See
> https://git.reviewboard.kde.org/r/119512/
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140804/cfa788ff/attachment.htm>


More information about the kde-core-devel mailing list