Review Request 119594: fix FileDialog size restorage

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119594/
-----------------------------------------------------------

(Updated Aug. 4, 2014, 11:57 vorm.)


Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, and Martin Klapetek.


Changes
-------

Misunderstanding - I tested the dir dialog explicitly ;-)


Summary (updated)
-----------------

fix FileDialog size restorage


Repository: frameworkintegration


Description (updated)
-------

- saving in the deconstrutor is insufficient,
  the dialog might survive the runtime
  -> needs to be saved when the dialog is finished or just closed
  (the closeEvent is not invoked if at least a sync dialog is finished)

- ensure a windowHandle and then restore the window size before calling ::exec()
    
- workaround an apparent QWidget QPA bug where even for a created platform window
  the QWindow geometry is not applied on the QWidget


Diffs (updated)
-----

  src/platformtheme/kdeplatformfiledialogbase.cpp b823bc7 
  src/platformtheme/kdeplatformfiledialogbase_p.h 8ef5b1e 
  src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 
  src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 

Diff: https://git.reviewboard.kde.org/r/119594/diff/


Testing
-------

See
https://git.reviewboard.kde.org/r/119512/


Thanks,

Thomas Lübking

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140804/24d6a613/attachment.htm>