Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

[Lukáš Tinkl]

> On Srp. 4, 2014, 1:13 dop., Lukáš Tinkl wrote:
> > No change here, ie. it doesn't restore the file dialog geometry.
> 
> Thomas Lübking wrote:
>     what is your precise testcase?
>     a bit remote because of your other patches: did you check that the correct platformtheme lib is used? (ran into this in a custom installation. self compiled plugin ended up in a different path than the distro qt5 plugin path)
>     is the size data updated in kdeglobals?
> 
> Lukáš Tinkl wrote:
>     Testcase: opening a filedialog in any Qt/KDE app, restarting the app -> default file/window size
>     
>     I guess I'm using the correct platformtheme, otherwise I wouldn't be seeing KDE fialogs right? Also, toplevel windows are not restored either
>     
>     Yup, the size is always correctly saved to the config files
> 
> Martin Klapetek wrote:
>     I can also confirm that file dialogs do not have their size restored with this patch (using tests/qfiledialogtest and also real dialogs around the workspace), however testing the dir selection does give me properly restored size dialog (./qfiledialogtest --staticFunction getExistingDirectory --modal on). Qt 5.3.1 here.

Because KDirSelectDialog doesn't use KWindowConfig:


void KDirSelectDialog::Private::readConfig(const KSharedConfig::Ptr &config, const QString &group)                               
{                                                                                                                                
    m_urlCombo->clear();                                                                                                         
                                                                                                                                 
    KConfigGroup conf(config, group);                                                                                            
    m_urlCombo->setHistoryItems(conf.readPathEntry("History Items", QStringList()));                                             
                                                                                                                                 
    const QSize size = conf.readEntry("DirSelectDialog Size", QSize());                                                          
    if (size.isValid()) {                                                                                                        
        m_parent->resize(size);                                                                                                  
    }                                                                                                                            
}


- Lukáš


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119594/#review63726
-----------------------------------------------------------


On Srp. 3, 2014, 9:16 odp., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119594/
> -----------------------------------------------------------
> 
> (Updated Srp. 3, 2014, 9:16 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, and Martin Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> summarized
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 
> 
> Diff: https://git.reviewboard.kde.org/r/119594/diff/
> 
> 
> Testing
> -------
> 
> See
> https://git.reviewboard.kde.org/r/119512/
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140804/c6f90f3a/attachment.htm>