Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

David Jarvie djarvie at kde.org
Mon Apr 14 12:48:51 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116951/
-----------------------------------------------------------

(Updated April 14, 2014, 11:48 a.m.)


Review request for kdelibs.


Changes
-------

Fix indentation.

Note to self: when working on systems with different editor settings, check whitespace settings ;)


Repository: kdelibs


Description
-------

When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox.


Diffs (updated)
-----

  kio/kio/kdbusservicestarter.cpp 90624fb 

Diff: https://git.reviewboard.kde.org/r/116951/diff/


Testing
-------

Tested this scenario, and it now returns the error string.


Thanks,

David Jarvie

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140414/fe1e663f/attachment.htm>


More information about the kde-core-devel mailing list