Review Request 117400: kdm: read DesktopNames from session file and export XDG_CURRENT_DESKTOP from it Add DesktopNames key to kdm sessions files.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117400/
-----------------------------------------------------------

(Updated April 11, 2014, 1:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for kde-workspace and Oswald Buddenhagen.


Repository: kde-workspace


Description
-------

kdm: read DesktopNames from session file and export XDG_CURRENT_DESKTOP from it

[after converting ';' (XDG list separator) to ':' (path separator)]

As discussed at the freedesktop summit.

XDG_CURRENT_DESKTOP is useful for OnlyShowIn and for the new mimeapps.list spec.

Add DesktopNames key to kdm sessions files.

This will be used by kdm (and other session managers) to set
XDG_CURRENT_DESKTOP when logging into such a desktop.

There is no written standard for session files but we agreed to this naming
and dm functinality at the freedesktop summit.


Diffs
-----

  kdm/backend/client.c 26bb0b4d56ebc87a0e8900b0936a90601a862603 
  kdm/kfrontend/sessions/gnome.desktop f4263dd7e75ed90e85ac0002f463c4e594a70f91 
  kdm/kfrontend/sessions/kde-plasma-safe.desktop.cmake 722091e3693e3fb86bd8983c1e0423a93a2b482d 
  kdm/kfrontend/sessions/kde-plasma.desktop.cmake 37413b6beea83b33880858502b451eda370cf8f4 
  kdm/kfrontend/sessions/lxde.desktop b794fb24e349627df35b82ee4cc722e5fad0090b 
  kdm/kfrontend/sessions/xfce.desktop c3362304edea90fd40d19e6c3f4a434ba780b490 
  kdm/kfrontend/sessions/xfce4.desktop 75c88a13eaf007c0149744c3f437d06532a398b6 

Diff: https://git.reviewboard.kde.org/r/117400/diff/


Testing
-------

Rebuilt OpenSuSE's kdm with the patch applied, commented out the setting of XDG_CURRENT_DESKTOP in startkde, logged into a session with DesktopNames=TEST --> echo $XDG_CURRENT_DESKTOP says TEST.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140411/e4ab65e6/attachment.htm>