Review Request 116602: fix setting "ssl_was_in_use" metadata

Commit Hook null at kde.org
Tue Apr 1 21:50:20 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116602/#review54820
-----------------------------------------------------------


This review has been submitted with commit 0d90552e3f3b9a4a13212391db48ed392b455411 by Andrea Iacovitti to branch master.

- Commit Hook


On March 27, 2014, 6:19 a.m., Andrea Iacovitti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116602/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 6:19 a.m.)
> 
> 
> Review request for kdelibs and Dawit Alemayehu.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> If incomingMetaData doesn't contain item with key "ssl_in_use" (and i verified this happen) using [] operator results in inserting a new item with key "ssl_in_use" and NullString value in incomingMetaData map and, as a consequence, a new item with key "ssl_was_in_use" and NullString value in outgoingMetaData map.
> This patch aims to avoid this situation by looking up the key using queryMetadata().
> 
> 
> Diffs
> -----
> 
>   kio/kio/job.cpp edc5fed 
> 
> Diff: https://git.reviewboard.kde.org/r/116602/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Iacovitti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140401/4b220212/attachment.htm>


More information about the kde-core-devel mailing list