Review Request 112869: Do not leak sockets in kdelibs

[Lukáš Tinkl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112869/#review40556
-----------------------------------------------------------

Ship it!


Ship It!

- Lukáš Tinkl


On Sept. 22, 2013, 2:21 p.m., Lamarque Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112869/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2013, 2:21 p.m.)
> 
> 
> Review request for kdelibs and Solid.
> 
> 
> Description
> -------
> 
> NetworkInterface::isWireless() in kdelibs/solid/solid/backends/udev/udevnetworkinterface.cpp does not close the socket it opens to call an ioctl leading to problem to kded4 that can affect plasma-desktop as well (temporary freezing plasma-desktop as described in the bug entry).
> 
> 
> This addresses bug 324954.
>     http://bugs.kde.org/show_bug.cgi?id=324954
> 
> 
> Diffs
> -----
> 
>   solid/solid/backends/udev/udevnetworkinterface.cpp 06dc907 
> 
> Diff: http://git.reviewboard.kde.org/r/112869/diff/
> 
> 
> Testing
> -------
> 
> Tested by the bug reporter and it fixes the problem for him.
> 
> 
> Thanks,
> 
> Lamarque Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130923/a4d2292f/attachment.htm>