Review Request 112880: Added KColorSchemeToken class.

Denis Kuplyakov dener.kup at gmail.com
Mon Sep 23 12:55:41 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
-----------------------------------------------------------

(Updated Sept. 23, 2013, 11:55 a.m.)


Review request for kdelibs.


Changes
-------

Fixed comments, C-style casts, formatting and trailing whitespace.


Description
-------

It is wrapper to access KColorScheme's methods from QML code.
Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code.

As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme.

More info:
* search for "KDE theme colors API for QML" thread at kdelibs and kdegames mailinglists *

NEED TO FIX:
I can't include it like #include <KColorSchemeToken> at KReversi's code, only "kcolorschemetoken.h". Maybe I've missed something?


Diffs (updated)
-----

  kdeui/CMakeLists.txt b439e04 
  kdeui/colors/kcolorscheme.h 17570fd 
  kdeui/colors/kcolorscheme.cpp a6650ac 
  kdeui/colors/kcolorschemetoken.h PRE-CREATION 
  kdeui/colors/kcolorschemetoken.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112880/diff/


Testing
-------

I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.


Thanks,

Denis Kuplyakov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130923/fc0c5793/attachment.htm>


More information about the kde-core-devel mailing list