Review Request 112880: Added KColorSchemeToken class.

[Denis Kuplyakov]

> On Sept. 22, 2013, 1:55 p.m., Kevin Krammer wrote:
> > kdeui/colors/kcolorschemetoken.h, line 55
> > <http://git.reviewboard.kde.org/r/112880/diff/1/?file=191110#file191110line55>
> >
> >     a property with a setter but no NOTIFYlooks wrong to me for a QML wrapper

All of the first seven properties are used only to set arguments to call apropriate KColorScheme method. It will be good to make them to be set once as KColorSchemeToken instance is created (like const in class). Is there a way to achive this?


- Denis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review40458
-----------------------------------------------------------


On Sept. 22, 2013, 10:17 a.m., Denis Kuplyakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112880/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2013, 10:17 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> It is wrapper to access KColorScheme's methods from QML code.
> Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code.
> 
> As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme.
> 
> More info:
> * search for "KDE theme colors API for QML" thread at kdelibs and kdegames mailinglists *
> 
> NEED TO FIX:
> I can't include it like #include <KColorSchemeToken> at KReversi's code, only "kcolorschemetoken.h". Maybe I've missed something?
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt b439e04 
>   kdeui/colors/kcolorscheme.h 17570fd 
>   kdeui/colors/kcolorscheme.cpp a6650ac 
>   kdeui/colors/kcolorschemetoken.h PRE-CREATION 
>   kdeui/colors/kcolorschemetoken.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112880/diff/
> 
> 
> Testing
> -------
> 
> I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.
> 
> 
> Thanks,
> 
> Denis Kuplyakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130922/9dd3ff2e/attachment.htm>