Review Request 112880: Added KColorSchemeToken class.
Denis Kuplyakov
dener.kup at gmail.com
Sun Sep 22 11:17:13 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
-----------------------------------------------------------
(Updated Sept. 22, 2013, 10:17 a.m.)
Review request for kdelibs.
Changes
-------
I don't know why but "Testing done" field was empty.
Description
-------
It is wrapper to access KColorScheme's methods from QML code.
Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code.
As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme.
More info:
* search for "KDE theme colors API for QML" thread at kdelibs and kdegames mailinglists *
NEED TO FIX:
I can't include it like #include <KColorSchemeToken> at KReversi's code, only "kcolorschemetoken.h". Maybe I've missed something?
Diffs
-----
kdeui/CMakeLists.txt b439e04
kdeui/colors/kcolorscheme.h 17570fd
kdeui/colors/kcolorscheme.cpp a6650ac
kdeui/colors/kcolorschemetoken.h PRE-CREATION
kdeui/colors/kcolorschemetoken.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/112880/diff/
Testing (updated)
-------
I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.
Thanks,
Denis Kuplyakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130922/db962aa0/attachment.htm>
More information about the kde-core-devel
mailing list