Review Request 102307: rate control in ftp kio slave with review comments fixes

[Lukas Appelhans]

> On Sept. 1, 2013, 8:51 a.m., David Faure wrote:
> > Hi. Do you plan on updating the patch once more? Sorry for the many iterations -- this what gives quality code in the end though.

Hey!
Thanks for the heads up here, I would like to see this in kdelibs/frameworks as well! If there is noone else willing to fix the remaining issues, I will do it! :)


- Lukas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102307/#review39055
-----------------------------------------------------------


On Aug. 11, 2011, 4:16 p.m., Tushar Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102307/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2011, 4:16 p.m.)
> 
> 
> Review request for kdelibs, Dawit Alemayehu, David Faure, Lukas Appelhans, Thiago Macieira, and Thomas Zander.
> 
> 
> Description
> -------
> 
> This patch is trying to clear the comments of the previous patch.(https://git.reviewboard.kde.org/r/102307/)
> 
> 
> Diffs
> -----
> 
>   kioslave/ftp/CMakeLists.txt e080b02 
>   kioslave/ftp/ftp.cpp 655524a 
>   kioslave/ftp/ratecontroller.h PRE-CREATION 
>   kioslave/ftp/ratecontroller.cpp PRE-CREATION 
>   kioslave/ftp/speedController.h PRE-CREATION 
>   kioslave/ftp/speedController.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tushar Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130919/101669ce/attachment.htm>