Review Request 112641: port about kio slave

David Faure faure at kde.org
Tue Sep 10 18:06:29 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112641/#review39742
-----------------------------------------------------------

Ship it!



kioslave/about/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112641/#comment29291>

    Can you add a comment after that line, to say why kde4support is used?
    
    Alternatively, port away from kde4support.


- David Faure


On Sept. 10, 2013, 4:13 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112641/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2013, 4:13 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Port about kio slave
> 
> 
> Diffs
> -----
> 
>   kioslave/CMakeLists.txt ff66ab6 
>   kioslave/about/CMakeLists.txt 4f8d91f 
>   kioslave/about/kio_about.h 620d6aa 
>   kioslave/about/kio_about.cpp d7396d8 
> 
> Diff: http://git.reviewboard.kde.org/r/112641/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130910/29389f76/attachment.htm>


More information about the kde-core-devel mailing list