Review Request 112602: Delay KDE class initialization to main loop

[Thomas Lübking]

> On Sept. 9, 2013, 3:46 p.m., Commit Hook wrote:
> > This review has been submitted with commit 2e5a2450762f8dedf9ffd77028ed06b3a39a807d by Weng Xuetian to branch KDE/4.11.

You forgot to remove the QTimer include.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112602/#review39654
-----------------------------------------------------------


On Sept. 9, 2013, 3:46 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112602/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2013, 3:46 p.m.)
> 
> 
> Review request for kde-workspace and Àlex Fiestas.
> 
> 
> Description
> -------
> 
> Gui platform plugin is loaded during QApplication construction, but it relies on some KApplication/QApplication data to work correctly.
> 
> This patch uses a QTimer::singleShot hack to delay the initialization to main loop, to ensure KApplication/QApplication is already constructed.
> 
> 
> This addresses bug 324574.
>     http://bugs.kde.org/show_bug.cgi?id=324574
> 
> 
> Diffs
> -----
> 
>   qguiplatformplugin_kde/qguiplatformplugin_kde.cpp ce22622 
> 
> Diff: http://git.reviewboard.kde.org/r/112602/diff/
> 
> 
> Testing
> -------
> 
> 324574 fixed. and other applications are unaffected.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130909/0ef769c6/attachment.htm>