Review Request 112528: Make it possible to preserve mtime for copy jobs not just move ones

David Faure faure at kde.org
Thu Sep 5 09:39:20 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112528/#review39398
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Sept. 5, 2013, 2:52 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112528/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2013, 2:52 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> This patch changes the current logic outlined at https://bugs.kde.org/show_bug.cgi?id=55804#c48 such that the copy/paste operations will also preserve the mtime. I have no idea why I chose to only not to send the "modified" meta-data for COPY requests. There really is no good reason for it and it is inconsistent with what kio_file does for local file copy operations.
> 
> 
> This addresses bug 55804.
>     http://bugs.kde.org/show_bug.cgi?id=55804
> 
> 
> Diffs
> -----
> 
>   kio/kio/job.cpp 8ff088c 
> 
> Diff: http://git.reviewboard.kde.org/r/112528/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130905/0e6a354e/attachment.htm>


More information about the kde-core-devel mailing list