Review Request 112458: Fix build with jpeg-9

Michael Pyne mpyne at kde.org
Thu Sep 5 04:57:40 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112458/#review39389
-----------------------------------------------------------

Ship it!


Change makes sense, tested here and works, please commit.

- Michael Pyne


On Sept. 4, 2013, 5:49 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112458/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 5:49 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Since jpeg-9, build fails: khtml/imload/decoders/jpegloader.cpp:145:20: error: cannot convert ‘bool’ to ‘boolean’ in return
> 
> This is because in jpeg-9, the boolean typedef changes from int to typedef enum { FALSE = 0, TRUE = 1 }.
> 
> 
> Diffs
> -----
> 
>   khtml/imload/decoders/jpegloader.cpp ea255726fdf1c310826c0037583aca3c5c741245 
> 
> Diff: http://git.reviewboard.kde.org/r/112458/diff/
> 
> 
> Testing
> -------
> 
> Also tested against jpeg-8d (previous stable) and libjpeg-turbo.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130905/b0245954/attachment.htm>


More information about the kde-core-devel mailing list