Review Request 112328: Add case sensitive sorting option to KGlobalSettings and KDirSortFilterProxyModel

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112328/#review39347
-----------------------------------------------------------


Thanks for the patch! I think that implementing this is a good idea (it really has been requested by quite a few users). I'm not quite sure though who is responsible for saying "Ship it!" for changes in these classes.

I have two small comments, see below.


kdeui/kernel/kglobalsettings.cpp
<http://git.reviewboard.kde.org/r/112328/#comment29000>

    KConfigGroup g(KGlobal::config(), "KDE");
    
    (No spaces inside (...) in new code.)



kdeui/kernel/kglobalsettings.cpp
<http://git.reviewboard.kde.org/r/112328/#comment29001>

    Could you explain briefly why this reparseConfiguration() call is needed now, and it was not needed before? It's not obvious to me at first sight.


- Frank Reininghaus


On Aug. 29, 2013, 1:11 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112328/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 1:11 p.m.)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Description
> -------
> 
> There are number of people who want to have case sensitive sorting in file manager and file dialogs (that would be consistent with locale settings).
> 
> The proposed patch adds a property to KGlobalSettings (caseSensitiveSorting()) and the new signal sortingModeChanged(), which deprecates naturalSortingChanged(), so the clients can connect to only one event and do not resort their models twice (maybe and option for the event to pass the change reason would be useful?).
> 
> KDirSortFilterProxyModel is changed in a trivial manner to use new event and handle case sensitivity changes.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=148550.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=148550
> 
> 
> Diffs
> -----
> 
>   kdeui/kernel/kglobalsettings.h 96da20e 
>   kdeui/kernel/kglobalsettings.cpp 2e3a7eb 
>   kfile/kdirsortfilterproxymodel.h 63cf04c 
>   kfile/kdirsortfilterproxymodel.cpp 34ddcd2 
> 
> Diff: http://git.reviewboard.kde.org/r/112328/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130904/f7672070/attachment.htm>