Review Request 113492: kio_http: set the application level proxy to NoProxy before making a direct connection to host (server or proxy)

[Andrea Iacovitti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113492/
-----------------------------------------------------------

(Updated Oct. 29, 2013, 5:40 p.m.)


Review request for kdelibs and Dawit Alemayehu.


Changes
-------

Latest changes to the patch will cause problems.
Suppose to use a PAC script that returns only one proxy (for simplicity).
If a request is made while network connection is temporarily down, the proxy address will be blacklisted
and you can not use it for the next 30 minutes, even if the network connection is back and working.
At this point i think it's better to commit only the changes this review was intended for, that is to resolve bug 326799.
I Uploaded a new diff that only address bug 326799.


Bugs: 326799
    http://bugs.kde.org/show_bug.cgi?id=326799


Repository: kdelibs


Description
-------

Make sure application level proxy is set to QNetworkProxy::NoProxy before connecting to remote host when no Qt application proxy is required, that is when not using socks proxy or tunneling SSL.
Also warn the user about collected bad proxies url, if any.


Diffs (updated)
-----

  kioslave/http/http.cpp 417569a 

Diff: http://git.reviewboard.kde.org/r/113492/diff/


Testing
-------


Thanks,

Andrea Iacovitti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131029/9fc2be88/attachment.htm>