Review Request 113492: kio_http: set the application level proxy to NoProxy before making a direct connection to host (server or proxy)

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113492/#review42624
-----------------------------------------------------------



kioslave/http/http.cpp
<http://git.reviewboard.kde.org/r/113492/#comment30882>

    This actually needs to be a dbus call to the proxyscout kded module.


Please remove the TODO in the badProxyUrls if block and add the following code instead:
   
   QDBusInterface proxyScout(QLatin1String("org.kde.kded"), QLatin1String("/modules/proxyscout"), QLatin1String("org.kde.KPAC.ProxyScout"));
   if (proxyScout.isValid()) {
     Q_FOREACH(const KUrl& url, badProxyUrls) {
       (void)proxyScout.asyncCall(QLatin1String("blackListProxy"), url.url());
     }
   }


- Dawit Alemayehu


On Oct. 28, 2013, 9:52 p.m., Andrea Iacovitti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113492/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2013, 9:52 p.m.)
> 
> 
> Review request for kdelibs and Dawit Alemayehu.
> 
> 
> Bugs: 326799
>     http://bugs.kde.org/show_bug.cgi?id=326799
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Make sure application level proxy is set to QNetworkProxy::NoProxy before connecting to remote host when no Qt application proxy is required, that is when not using socks proxy or tunneling SSL.
> Also warn the user about collected bad proxies url, if any.
> 
> 
> Diffs
> -----
> 
>   kioslave/http/http.cpp 417569a 
> 
> Diff: http://git.reviewboard.kde.org/r/113492/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Iacovitti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131029/82c86f2f/attachment.htm>