Review Request 113493: Fix entering kcm_kdm resets settings of current session

Oswald Buddenhagen ossi at kde.org
Tue Oct 29 08:01:55 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113493/#review42574
-----------------------------------------------------------

Ship it!


pushed to 4.11. the git history suggests that it will be forward-merged to master at some point...

- Oswald Buddenhagen


On Oct. 28, 2013, 11:14 p.m., Luc Menut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113493/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2013, 11:14 p.m.)
> 
> 
> Review request for kde-workspace and Oswald Buddenhagen.
> 
> 
> Bugs: 254430
>     http://bugs.kde.org/show_bug.cgi?id=254430
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Entering the Login Screen module from systemsettings adds system-wide values (from system kdeglobals) to user values in ~/.kde/share/config/kdeglobals.
> Thus, lot of user settings are lost (font, style, colors, default Web Browser, ...).
> 
> Opening backgroundrc (line 306) with KConfig::SimpleConfig OpenFlag (like for kdmrc at line 285) fixes this issue. This fix was proposed by Pulfer in bugreport 254430#c16.
> 
> regards,
> Luc Menut - Mageia
> 
> PS: I don't have write access to kde git, so could you commit the change if the patch looks fine. Thanks.
> 
> 
> Diffs
> -----
> 
>   kdm/kcm/main.cpp 8560c89 
> 
> Diff: http://git.reviewboard.kde.org/r/113493/diff/
> 
> 
> Testing
> -------
> 
> tested with KDE 4.11.2 (Mageia Cauldron)
> 
> 
> Thanks,
> 
> Luc Menut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131029/3165b8ce/attachment.htm>


More information about the kde-core-devel mailing list