Review Request 103808: Report file errors when extracting files using karchive

[Mario Bensi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103808/#review42511
-----------------------------------------------------------


In fact, I prefer you return the QFile::FileError from copyTo
Another solution will be copyTo return a bool and we add two method errorCode()/errorString() but not only for KArchiveFile but for all KArchiveEntry and in this case we need to determine if we use a QFile::Error or a specific enum.

- Mario Bensi


On Oct. 27, 2013, 7:03 p.m., Theofilos Intzoglou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103808/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2013, 7:03 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> A simple patch to check if something goes wrong when extracting files from an archive. You can read the error code using copyToErrorCode()
> 
> 
> Diffs
> -----
> 
>   kdecore/io/karchive.h 7cd7c0c 
>   kdecore/io/karchive.cpp 86d61d5 
> 
> Diff: http://git.reviewboard.kde.org/r/103808/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Theofilos Intzoglou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131028/64f57e03/attachment.htm>