Review Request 113429: Added utility function for converting KIO permissions (mode_t) to QFile::Permissions

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113429/#review42509
-----------------------------------------------------------

Ship it!


Thanks, looks OK now. The test could be simplified though, but feel free to commit either way.


kio/tests/globaltest.cpp
<http://git.reviewboard.kde.org/r/113429/#comment30830>

    This set of 9 QCOMPARE calls could be simplified to a single
    QCOMPARE(qPermissions, QFile::ReadOwner|QFile::WriteOwner|QFile::ExeOwner);
    


- David Faure


On Oct. 28, 2013, 5:14 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113429/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2013, 5:14 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This patch adds a utility function in kio/global.h for converting KIO permissions which are expressed in mode_t to QFile::Permissions.
> 
> 
> Diffs
> -----
> 
>   kio/tests/globaltest.h PRE-CREATION 
>   kio/tests/CMakeLists.txt 1019312 
>   kio/kio/global.h 9a63c7f 
>   kio/kio/global.cpp 37efe46 
>   kio/tests/globaltest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113429/diff/
> 
> 
> Testing
> -------
> 
> unit tests.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131028/d56d1a2c/attachment.htm>