Review Request 113360: PolkitActionsKCM: Use a simple pointer for m_actionWidget.
Ivan Shapovalov
intelfx100 at gmail.com
Sun Oct 27 22:01:17 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113360/
-----------------------------------------------------------
(Updated Oct. 27, 2013, 10:01 p.m.)
Review request for kde-workspace and Polkit KDE Configuration.
Changes
-------
Added kde-workspace group to reviewers (like in #111093). Hope somebody will review this...
Repository: polkit-kde-kcmodules-1
Description
-------
QPointer<> crashes for me (Arch), the crash is non-debuggable (only in Release mode) and I do not see a way how can m_actionWidget suddenly disappear.
Diffs
-----
polkitactions/PolkitActionsKCM.h 84c6581
polkitactions/PolkitActionsKCM.cpp a88bf65
Diff: http://git.reviewboard.kde.org/r/113360/diff/
Testing
-------
- Ensured that it fixes the crash for me
- Made some test modifications and ensured that it does not crash in other places
Thanks,
Ivan Shapovalov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131027/a6997ea1/attachment.htm>
More information about the kde-core-devel
mailing list