Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

[Johannes Obermayr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111042/
-----------------------------------------------------------

(Updated Oct. 27, 2013, 6:51 p.m.)


Status
------

This change has been discarded.


Review request for kdelibs.


Repository: kdelibs


Description
-------

Distributions should upstream their patches / changes:
- Upstream / other distributions can easily see distro specific changes and enable them by default by removing "#if defined(DISTRO_xxx)"
- Maybe duplicate work can be avoided and other distributions can easily use them by "|| defined(DISTRO_xxx)"
- Less adaptions of downstream patches ...


Diffs
-----

  CMakeLists.txt 705c84e 
  kdecore/config/kconfig.cpp 048605d 
  kdecore/config/kconfig_p.h 7751242 
  kdecore/config/kconfigdata.h e5dd7da 
  kdecore/config/kconfiggroup.h 8eddfd5 
  kdecore/config/kconfiggroup.cpp 9e73eb7 
  kdecore/config/kdesktopfile.h 1c4eae6 
  kdecore/config/kdesktopfile.cpp 54e5910 
  kdecore/kdebug.areas 29a4415 
  kdecore/localization/klocale_kde.cpp b010e74 
  kdecore/services/kservice.h 3843bad 
  kdecore/services/kservice.cpp e2cc86f 
  kdecore/services/kservicegroup.h 9fdf2b0 
  kdecore/services/kservicegroup.cpp 08bc587 
  kdecore/services/kservicegroup_p.h 5f21497 
  kded/vfolder_menu.cpp f0b0b35 
  kdesu/defaults.h 706a088 
  kdeui/kernel/kglobalsettings.cpp 2e3a7eb 
  khtml/html/html_objectimpl.cpp f0f590d 
  kio/CMakeLists.txt 4854829 
  kio/kio/kprotocolmanager.cpp 05bb547 
  kio/kio/krun.cpp ad5656e 
  kjs/collector.cpp cdd8421 
  plasma/containment.h e725a99 
  plasma/containment.cpp fc2ca70 
  plasma/private/containment_p.h 75a6f80 
  plasma/theme.cpp 4554de7 
  suseinstall/CMakeLists.txt PRE-CREATION 
  suseinstall/kbuildsycocaprogressdialog.h PRE-CREATION 
  suseinstall/kbuildsycocaprogressdialog.cpp PRE-CREATION 
  suseinstall/ksuseinstall.h PRE-CREATION 
  suseinstall/ksuseinstall.cpp PRE-CREATION 
  suseinstall/ksuseinstall_export.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111042/diff/


Testing
-------


Thanks,

Johannes Obermayr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131027/e068bf7f/attachment.htm>