Review Request 113429: Added utility function for converting KIO permissions (mode_t) to QFile::Permissions

[David Faure]

> On Oct. 27, 2013, 8:20 a.m., David Faure wrote:
> > Please use ReadUser instead of ReadOwner (like the function in the frameworks branch does).
> > 
> > ReadUser would be wrong on Windows ("returns the rights of the current user").
> 
> Dawit Alemayehu wrote:
>     Ahh... that is what I am using.

Oops my first line is the wrong way around.

ReadUser = wrong (due to Windows)
ReadOwner = right


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113429/#review42414
-----------------------------------------------------------


On Oct. 25, 2013, 1:15 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113429/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2013, 1:15 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This patch adds a utility function in kio/global.h for converting KIO permissions which are expressed in mode_t to QFile::Permissions.
> 
> 
> Diffs
> -----
> 
>   kio/kio/global.h 9a63c7f 
>   kio/kio/global.cpp 37efe46 
>   kio/tests/CMakeLists.txt 1019312 
>   kio/tests/globaltest.h PRE-CREATION 
>   kio/tests/globaltest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113429/diff/
> 
> 
> Testing
> -------
> 
> unit tests.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131027/f704d862/attachment.htm>