Review Request 113429: Added utility function for converting KIO permissions (mode_t) to QFile::Permissions

[Dawit Alemayehu]

> On Oct. 25, 2013, 1:55 p.m., Martin Klapetek wrote:
> > Note, that in the frameworks branch, this same function already exists in kioslave/file/file.cpp, line 97. 
> > 
> > I'd be for adopting this to frameworks too, including the unit tests.

Oh. I did not realize that or I would have copied that one. Anyhow, yes this one needs to be adapted in the frameworks branch because other ioslaves besides kio_file need it as well.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113429/#review42357
-----------------------------------------------------------


On Oct. 25, 2013, 1:15 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113429/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2013, 1:15 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This patch adds a utility function in kio/global.h for converting KIO permissions which are expressed in mode_t to QFile::Permissions.
> 
> 
> Diffs
> -----
> 
>   kio/kio/global.h 9a63c7f 
>   kio/kio/global.cpp 37efe46 
>   kio/tests/CMakeLists.txt 1019312 
>   kio/tests/globaltest.h PRE-CREATION 
>   kio/tests/globaltest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113429/diff/
> 
> 
> Testing
> -------
> 
> unit tests.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131026/0f5cc1f2/attachment.htm>