Review Request 113364: kio_http: fix for proxy connection

[Andrea Iacovitti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113364/
-----------------------------------------------------------

(Updated Oct. 21, 2013, 1:41 p.m.)


Review request for kdelibs and Dawit Alemayehu.


Changes
-------

Added "Description:" and "Testing Done:"


Repository: kdelibs


Description (updated)
-------

Fix the code to determine if a proxy or direct connection should be made in the case where multiple proxies are availables and between them the keyword "DIRECT" is present. We should first verify if the candidate proxy string is equal to "DIRECT" (and then try to make a direct connection) and after try to construct KUrl object.
Otherwise we would never be able to direct connect because KUrl("DIRECT") is not a valid (proxy) url.


Diffs
-----

  kioslave/http/http.cpp 81182eb 

Diff: http://git.reviewboard.kde.org/r/113364/diff/


Testing (updated)
-------

Tested against various PAC scripts returning, for example, proxies list like:
("http://127.0.0.1:3333", "DIRECT") or ("DIRECT", "http://127.0.0.1:3333")

Note: in case PAC script returns "DIRECT" only, this code path is not executed as m_request.proxyUrls will be empty.


Thanks,

Andrea Iacovitti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131021/151565cb/attachment.htm>